Fix dereferencing zeroth element of empty vector #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbatko-ge
force-pushed
the
fix-dereferencing-zeroth-element-of-empty-vector
branch
from
fc424cf
to
521a339
Compare
|
A (simpler) fix that does not require C++11 was committed today as commit #169030f5a. |
michaelonken
pushed a commit
that referenced
this pull request
May 28, 2024
class DcmTLSCiphersuiteHandler contains two methods that sort a list of ciphersuites. This caused an access violation of the list to be sorted was empty (which could never happen with the command line tools, but was possible in user code if no security profile was activated). This is now fixed. Thanks to Piotr Batko <Piotr.Batko@gehealthcare.com> for the bug report. This closes GitHub pull request #97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is undefined behavior. In MSVC results in failed assertion in debug build.
Note:
std::vector::datais available since C++11. If you want to support pre-C++11 standards, this changes should be rewritten.